Deprecate map_into_symmetry_reduced_zone() in favor of reduce()#590
Merged
argerlt merged 11 commits intopyxem:developfrom Sep 29, 2025
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…ne() Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
…zy loading was introduced Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
hakonanes
approved these changes
Sep 28, 2025
Member
hakonanes
left a comment
There was a problem hiding this comment.
Thanks for making this PR!
I added a few extra internal improvements. I'd appreciate it if you could glance over them before merging.
Signed-off-by: Håkon Wiik Ånes <hwaanes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
#558 was having a bad case of scope creep, so I'm breaking it up into some concise additions.
Additionally, some recent folder renaming and style changes meant a rebase made fore a confusing commit history.
This PR just depreciated
map_into_symmetry_reduced_zonetoreduce. Some clarifying code commentswere added, but other than that functionality is identical to before.
Progress of the PR
Minimal example of the bug fix or new feature
Before:
>>> M.map_into_symmetry_reduced_zone()After:
>>> M.reduce()For reviewers
__init__.py.section in
CHANGELOG.rst.__credits__inorix/__init__.pyand in.zenodo.json.