Skip to content

Qaoa implementation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TheGupta2012 wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Qaoa implementation #79

TheGupta2012 wants to merge 18 commits into from

Conversation

@TheGupta2012
Copy link
Member

@TheGupta2012 TheGupta2012 commented Jan 21, 2026

Changes

@lcicala
Sketch of first implementations
21c39ed
@lcicala
Implementation of QAOA maxcut functions
508a88e
@lcicala
Organized code inside QAOA class
7cec9d4 
Added missing functionalities (reset, cswap, input and output variables) to std_gates class
@lcicala
Added xy_mixer, x_mixer
a6c97fd 
Added min_vertex_cover_cost, max_clique_cost
Added comments
TheGupta2012
TheGupta2012 commented Jan 21, 2026
View reviewed changes
@lcicala lcicala self-assigned this Jan 22, 2026
@lcicala lcicala requested a review from ryanhill1 January 22, 2026 15:58
@lcicala
Copy link
Collaborator

lcicala commented Jan 26, 2026

Have a look at the test.ipynp notebook contained inside the qaoa directory to have an idea of the implementation

TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
TheGupta2012
TheGupta2012 commented Jan 29, 2026
View reviewed changes
Copy link
Member Author

@TheGupta2012 TheGupta2012 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lorenzo, thank you for all the changes! I like the extensible setup of the qaoa class where we can build an application program by calling a method, like setup_maxcut.

I've given some comments about implementation details, but overall it looks good. Can you please add some unit tests for your implementation under the tests dir and clean up the documentation strings for QAOA?

@lcicala
Added validation on size of the graph
fe57828 
Removed class level variables
Removed unnecessary comment blocks
Fixed comment which didn't match the method body
removed name check in qasm variable declaration
@lcicala
Added references to Hamiltonian subroutine definitions
cf44b77
@TheGupta2012 TheGupta2012 marked this pull request as ready for review January 29, 2026 14:53
@codecov
Copy link

codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.12644% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
qbraid_algorithms/qtran/gate_library.py 83.33% 4 Missing ⚠️
qbraid_algorithms/qaoa/qaoa.py 99.31% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcicala lcicala lcicala left review comments

@ryanhill1 ryanhill1 Awaiting requested review from ryanhill1

At least 1 approving review is required to merge this pull request.

Assignees

@lcicala lcicala

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheGupta2012 @lcicala