Basiav/sampleset info extraction

[basiav]

Added optional DWave sampleset metadata extraction (https://docs.dwavequantum.com/en/latest/quantum_research/operation_timing.html).

Added optional time measurements to Advantage with units:

• find_embedding(),
• find_clique_embeding(),
• .sample(),
• creating FixedEmbeddingComposite object (not necessary for the future but just to make sure for now).

[kacper3615]

Didn't we consider that the flag that refers to measuring time should be in the method, not in the whole class?

[basiav]

I opened up an issue related to this: #57 (comment) (and your kacper3615/penalty_weights btw).

Please take a look at the Advantage.init function:

QHyper/QHyper/solvers/quantum_annealing/dwave/advantage.py

Line 89 in 3750127

if use_clique_embedding:

As we put the find_clique_embedding func. call in the .init (and rightly, follows later on why) and the timing measurements are optional, some flag needs to determine it.

Please note that a similar issue occurs with penalty_weights due to the same reason of find_clique_embedding in the .init.

[kacper3615]

It should be changed based on the changes suggested in the comment above

[basiav]

Not sure I understand this one, could you take a look at it if it's ok now or describe it once again?

[kacper3615]

Here there should be no mesure_time flag. Unless we want to measure time we should not perform this method, so I would remove this flag

[basiav]

Please take a look of how this method is called in the code.

The idea of this function is to wrap a function with the start = time.perf_counter() and end = time.perf_counter() clauses to facultatively measure function's execution time.
It is to avoid explicit "ifs" in the .solve code in many places (4 function calls to measure) (boilerplate).

Please let me know if you'd like to:

• stay with the execute_timed function - minimal overhead, quickest.
• a decorator function - esthetic reasons, minimally slower.

Unless we want to always measure time - the execution overhead is nothing - just time.perf_counter call). But I wouldn't do it, it's unclean.

[kacper3615]

I wrote comments next to the proposed changes

[basiav]

1. I have corrected the obvious changes and commented on the non-obvious ones - what I haven't changed and why not.
2. I've opened up an issue, common to my changes and your penalty_weights

#57 (comment)

which is software engineering problem.

It also regards kacper3615/bug_fixes.