Open
Conversation
basiav
reviewed
Oct 29, 2025
basiav
reviewed
Oct 29, 2025
Collaborator
There was a problem hiding this comment.
I left comments next to the proposed change. Overall:
- Just one minor change in the ValueError message.
- Please do a correspondant PR in Qommunity - with kacper3615/bug_fixing, so that the changes made in QHyper are handled in Qommunity and I can review.
- Suggestion - maybe let's use a formatter (e.g. black) - the ValueError message got long.
basiav
reviewed
Nov 10, 2025
Comment on lines
+56
to
+57
| version: str | None = None, | ||
| region: str | None = None, |
Collaborator
There was a problem hiding this comment.
version and region arguments are not assigned to Advantage attributes nor used:
This is some small error.
This is probably a mistake from your refactoring, so please check it and make sure you didn't delete anything else while deleting the "hyper_optimizer" part and other parts of the code.
basiav
reviewed
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.