feat(statefulset): add containerSecurityContext to init containers#178
Open
Johannes- wants to merge 1 commit intoqdrant:mainfrom
Open
feat(statefulset): add containerSecurityContext to init containers#178Johannes- wants to merge 1 commit intoqdrant:mainfrom
Johannes- wants to merge 1 commit intoqdrant:mainfrom
Conversation
mac-chaffee
reviewed
May 3, 2024
| volumeMounts: | ||
| - name: qdrant-storage | ||
| mountPath: /qdrant/storage | ||
| {{- with .Values.containerSecurityContext }} |
Contributor
There was a problem hiding this comment.
Hi @Johannes- , thanks for the contribution!
As mentioned here: #130 I think this would break by default since the init container needs to run as root, but using the default containerSecurityContext will make it run as user 1000.
Instead of re-using containerSecurityContext, could it be controlled by a new, separate setting called initContainerSecurityContext? May lead to duplication in peoples' values, but it allows people to assign different security contexts to each.
Contributor
There was a problem hiding this comment.
Also in #177 I removed the second init container, consolidating them into a single init container. That's probably what the merge conflict is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The containerSecurityContext is already partially utilized within the init containers. Therefore, it would make sense to extend its application as a securityContext to the initContainers as well.