Skip to content

修改一些mcp的描述#71

Open
liuzhe910422 wants to merge 1 commit into
qiniu:mainfrom
liuzhe910422:mcp2
Open

修改一些mcp的描述#71
liuzhe910422 wants to merge 1 commit into
qiniu:mainfrom
liuzhe910422:mcp2

Conversation

@liuzhe910422

Copy link
Copy Markdown
Contributor

No description provided.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one documentation issue in the updated MCP vision guidance.

curl -X POST "https://xrobo-io.qiniuapi.com/mcp/vision/explain" \
-H "Authorization: Bearer xxx" \
curl -X POST "<capabilities.vision.url>" \
-H "Authorization: Bearer <capabilities.vision.token>" \

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hardware-mcp.md now documents capabilities.vision.token as optional, but this curl example always sends Authorization: Bearer <capabilities.vision.token>. If the platform omits the token, implementers may still send an empty or literal placeholder bearer token and fail requests. Please make this header conditional here, or make the initialize example say the token is required.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MCP protocol documentation to wrap messages in a standard envelope containing "type": "mcp" and "payload", removes the "session_id" field, and updates the camera feature guide to dynamically retrieve the vision analysis URL and token from the initialization capabilities. Feedback suggests ensuring documentation consistency by removing "session_id" from other related files, and replacing placeholders in JSON examples with valid URLs to keep the JSON syntax valid.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

{
"session_id": "...", // 会话ID
"type": "mcp", // 消息类型,固定为"mcp"
"type": "mcp", // 消息类型,固定为"mcp"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

在此处删除了 session_id 字段以规范 MCP 消息结构。但请注意,在 docs/xrobot/guide/camera-feature.md 的第 90 行(MCP 响应格式示例中)仍然保留了 "session_id": "XXXXXX"。为了保持文档的一致性,建议后续也将该文件中的 session_id 字段予以清除。

"sampling": {},
// 摄像头视觉相关(可选)
"vision": {
"url": "<视觉分析接口地址>", // 图片处理地址,设备端从此字段读取

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

为了确保 JSON 示例是合法的 JSON 格式(方便读者直接复制到 JSON 校验工具或 Mock 服务中),建议使用具体的示例 URL(例如 https://api.example.com/mcp/vision/explain)来代替 <视觉分析接口地址> 占位符。

Suggested change
"url": "<视觉分析接口地址>", // 图片处理地址,设备端从此字段读取
"url": "https://api.example.com/mcp/vision/explain", // 图片处理地址,设备端从此字段读取

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants