Skip to content

fix(ui): truncate long identifiers#25

Merged
miclle merged 2 commits into
qiniu:mainfrom
miclle:fix/truncate-long-ui-text
Jul 13, 2026
Merged

fix(ui): truncate long identifiers#25
miclle merged 2 commits into
qiniu:mainfrom
miclle:fix/truncate-long-ui-text

Conversation

@miclle

@miclle miclle commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • truncate long job and workflow labels in the ordinary-user Jobs view
  • constrain long runner identifiers in admin overview cards and runner request rows
  • cap long runner spec, group, and policy table columns without affecting status or action columns

Why

Long workflow and runner identifiers could expand flex and table content beyond the intended layout instead of displaying an ellipsis.

Validation

  • npm run lint
  • npm run build

Constrain long job, workflow, runner, and policy labels so they do not overflow cards and tables.
@miclle miclle marked this pull request as ready for review July 13, 2026 02:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces layout improvements across several UI components by adding text truncation and max-width constraints to prevent overflow. The reviewer feedback correctly points out that applying truncation classes directly to TableCell elements is unreliable due to their default display: table-cell styling. It is recommended to wrap the text content in block-level elements, such as a div, and apply the truncation and max-width classes to those inner elements instead.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ui/src/components/runner-groups-section.tsx Outdated
Comment thread ui/src/components/runner-policies-section.tsx Outdated
Comment thread ui/src/components/runner-specs-section.tsx Outdated

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this review. I reviewed the changed UI truncation classes across the admin tables, overview cards, runner requests list, and user dashboard job fields.

Verification not run: review-only pass; dependencies are not installed in ui/node_modules.

Apply ellipsis styles to block-level cell content so truncation remains reliable with automatic table layout.
@miclle miclle merged commit 6359eef into qiniu:main Jul 13, 2026
10 checks passed
@miclle miclle deleted the fix/truncate-long-ui-text branch July 13, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant