Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,19 @@
"dist"
],
"dependencies": {
"@inquirer/search": "^3.2.2",
"@inquirer/select": "^4.2.1",
"@inquirer/checkbox": "^5.1.5",
"@inquirer/confirm": "^6.0.13",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

依赖项中新增了 @inquirer/confirm,但在代码中并未实际使用。promptHelper.confirm 目前是基于 @inquirer/select 实现的列表式确认。如果确定不需要标准的 (y/N) 确认框,建议移除此依赖以保持 package 简洁。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low: @inquirer/confirm is added as a production dependency but the migrated helper still implements confirm() with @inquirer/select, and there are no imports of @inquirer/confirm elsewhere. Please drop this dependency (and the corresponding lockfile entries) or switch promptHelper.confirm to use it, otherwise installs include an unused package.

"@inquirer/input": "^5.0.13",
"@inquirer/password": "^5.0.13",
"@inquirer/search": "^4.1.9",
"@inquirer/select": "^5.1.5",
"chalk": "^5.3.0",
"commander": "^12.1.0",
"inquirer": "^9.2.12",
"js-yaml": "^4.1.0",
"ora": "^8.0.1",
"terminal-link": "^5.0.0"
},
"devDependencies": {
"@types/inquirer": "^9.0.7",
"@types/js-yaml": "^4.0.9",
"@types/node": "^20.11.0",
"typescript": "^5.3.3"
Expand Down
Loading