Skip to content

FIX: check the correct env-var: #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IoannisNezis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX: check the correct env-var: #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/qlever/commands/ui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,8 @@ def additional_arguments(self, subparser) -> None:

def execute(self, args) -> bool:
# If QLEVER_OVERRIDE_DISABLE_UI is set, this command is disabled.
qlever_is_running_in_container = environ.get(
"QLEVER_IS_RUNNING_IN_CONTAINER"
)
if qlever_is_running_in_container:
qlever_override_disable_ui = environ.get("QLEVER_OVERRIDE_DISABLE_UI")
if qlever_override_disable_ui:
log.error(
"The environment variable `QLEVER_OVERRIDE_DISABLE_UI` is set, "
"therefore `qlever ui` is not available (it should not be called "
Expand Down Expand Up @@ -158,7 +156,7 @@ def execute(self, args) -> bool:
else:
commands_to_show.append(set_config_cmd)
self.show("\n".join(commands_to_show), only_show=args.show)
if qlever_is_running_in_container:
if qlever_override_disable_ui:
return False
if args.show:
return True
Expand Down Expand Up @@ -198,8 +196,7 @@ def execute(self, args) -> bool:
run_command(get_db_cmd)
except Exception as e:
log.error(
f"Failed to get {ui_db_file} from {args.ui_image} "
f"({e})"
f"Failed to get {ui_db_file} from {args.ui_image} ({e})"
)
return False

Expand Down
Loading