Validate the index after rebuild-index#287
Open
hannahbast wants to merge 7 commits intomainfrom
Open
Conversation
added 6 commits
May 3, 2026 21:19
When the API call `cmd=rebuild-index` to QLever succeeds, this does not necessarily mean that the index is valid. This could lead to a situation where the old index was replaced with an invalid new index. With this change, the new index is validated before moving it to a new location or deleting the old index. The index is validated by starting a server with that index on a random free port and issuing a simple query to it. Only if the validation succeeds, does the command continue as before. On the side, change the name of the option `--keep-old-index-dirs` to `--keep-previous-index-dirs`, which now has the options `all`, `none`, `original-only`, `most-recent-only`, and `original-and-most-recent`, where the latter is the new default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the API call
cmd=rebuild-indexto QLever succeeds, this does not necessarily mean that the index is valid. This could lead to a situation where the old index was replaced with an invalid new index.With this change, the new index is validated before moving it to a new location or deleting the old index. The index is validated by starting a server with that index on a random free port and issuing a simple query to it. Only if the validation succeeds, does the command continue as before.
On the side, change the name of the option
--keep-old-index-dirsto--keep-previous-index-dirs, which now has the optionsall,none,original-only,most-recent-only, andoriginal-and-most-recent, where the latter is the new default.