Bump minimum python version#289
Open
Qup42 wants to merge 2 commits intoqlever-dev:mainfrom
Open
Conversation
remove old (now officially unsupported) versions and add new versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the correct minimum python version of
3.10in thepyproject.tomland update the unit test workflow (drop old versions and add new versions).Python 3.10 seems reasonable. It is the oldest version that is still officially supported with updates and the oldest version that we package for. The requirement for 3.10 is caused by:
importlib.resources.as_fileandimportlib.resources.filesinserve_evaluation_app.pyrequire 3.9platform.freedesktop_os_releaseinsystem_info.pyrequires 3.10Note: This PR aligns the
pyproject.tomlwith the code. Support for older versions is likely possible if needed.platform.freedesktop_os_releasecould be replaced with thedistropackage.Closes ad-freiburg/qlever#2847