fix: harden settle pipeline without changing SettlementMode - #57
Merged
Conversation
Route upto overrides through ResourceServer settle hooks, allow empty success transactions for batch vouchers, tighten batch request-path verification, check auth-capture receipt status, and structure MCP StillRequired for caller recovery. Keep Sequential/Concurrent/Background.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post–PR #56 hardening that does not change the three settlement modes
(Sequential / Concurrent / Background).
ResourceServer::settle_payment(..., overrides)— resolve amountoverrides before hooks; HTTP Sequential upto uses this path only.
isValid: falserunson_verify_failurerecovery.transactionallowed (batch-settlement vouchers).atomic memory
try_charge; docs clarify request-path scope.receipt.status()is false.StillRequired { payment_required, recovery_requested }.Code review (pre-PR)
Self-review against AGENTS.md and fund/wire correctness:
just all+just testgreen.Test plan
just alljust test