fix: deal name search param + document verified filter formats - #21
Merged
Conversation
- Deal name search: q_keywords is silently ignored by /opportunities/search; q_opportunity_name actually filters. DEAL_SEARCH_FILTERS now allows q_opportunity_name (and rejects q_keywords). +test. - Enriched search_contacts/accounts/deals/people docstrings with the empirically-verified accepted formats (seniority enums, 'min,max' employee ranges, location formats, dict ranges, email-status values, canonical linkedin_url, deal name param, sort fields). - Added a Search-filter formats note to CLAUDE.md quirks. All formats were live-verified (each filter measurably reduces results). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Looks good. Switching deal name search to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from an empirical audit that exercised every search filter live (baseline vs filtered total) to confirm each one actually reduces results and to capture its accepted format.
Bug fixed
Deal name search never worked.
search_deals/deals search --querysendq_keywords, which Apollo silently ignores on/opportunities/search(a nonsense keyword still returned all 284 deals). The working param isq_opportunity_name("NORRIQ"→ 1).DEAL_SEARCH_FILTERSnow allowsq_opportunity_nameand rejectsq_keywords. (A companion CLI PR mapsdeals search --query→q_opportunity_name.)Docs — accepted formats now in the docstrings
Empirically verified and documented per
search_*:person_seniorities— lowercase enums (owner, vp, c_suite, …); uppercase/free-text → 0 rows.organization_num_employees_ranges—"min,max"comma ("1-10"dash is silently ignored).person_locations/organization_locations— country name, 2-letter code ("US"≡"United States"), or"City, State, Country".revenue_range/organization_num_jobs_range—{"min":N,"max":N};contact_email_statusvalues; canonicallinkedin_url; sort fields.Also added a filter-formats note to
CLAUDE.md.Testing
No version bump (release PR will handle it).
🤖 Generated with Claude Code