fix: drop calls/news commands for removed API endpoints; fix jobs columns - #13
Merged
Conversation
…umns Apollo removed the nested sub-resource routes these relied on (see apollo-api fix/remove-dead-list-endpoints): - Remove 'news list' (list_account_news is gone; no replacement). - Remove 'calls list' (list_contact_calls is gone); 'calls search' stays. - 'jobs list' now surfaces the organization_job_postings shape returned by the fixed list_account_jobs: columns Title/City/State/URL/Posted (was Location/Department, which the new shape doesn't carry). End-to-end verified against the fixed api: jobs list → 395 postings, calls search → 221, news command removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Looks good — clean removal of [Improvement] Docs/changelog may now be stale
Found 1 issue (0 critical, 1 improvement). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to apollo-api#20 (which removed
list_contact_calls/list_account_newsand rewiredlist_account_jobs).Changes
news list—list_account_newsis gone (Apollo removed/accounts/{id}/news, no replacement).calls list—list_contact_callsis gone;calls searchstays (uses the still-workingsearch_calls).jobs list— columns updated to theorganization_job_postingsshape the fixedlist_account_jobsreturns:Title / City / State / URL / Posted(the oldLocation/Departmentfields aren't in the new shape).Testing
newsgone,callsdown tosearch,jobspresent.jobs list→ 395 postings,calls search→ 221,newscommand removed.Notes
qodev-apollo-apifloor here (or fold into a CLI release PR). CI passes today because the removed methods still exist in the pinned api build and nothing references them anymore.🤖 Generated with Claude Code