fix: deals --query searches deal name; document filter formats in skill - #14
Merged
Conversation
- deals search --query now maps to q_opportunity_name (Apollo silently ignores q_keywords for /opportunities/search, so name search never worked). - SKILL.md: add a 'Search filter formats' section (seniority enums, location formats, 'min,max' employee ranges, dict ranges, deal name search, canonical linkedin_url). Fix staleness: add 'deals create' and 'people --keywords', remove the deleted 'news' command, correct 'jobs' to 'jobs list ACCOUNT_ID'. - deal-workflows.md: clarify --query matches the deal name. e2e verified against the fixed api: deals search --query NORRIQ → 1, nonsense → 0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![peqy[bot]](https://avatars.githubusercontent.com/in/1930020?s=60&v=4){kind=small}
There was a problem hiding this comment.
Change looks correct: deals search --query now maps to q_opportunity_name and docs clarify filter formats.
Improvement
- Consider bumping the minimum
qodev-apollo-apiversion once apollo-api#21 is released, so older installs don’t silently ignoreq_opportunity_nameand return unfiltered results.
Found 1 issue (0 critical, 1 improvement).
| filters["q_keywords"] = query | ||
| # Deal name search is q_opportunity_name — Apollo silently ignores | ||
| # q_keywords on /opportunities/search (it returns every deal). | ||
| filters["q_opportunity_name"] = query |
There was a problem hiding this comment.
q_opportunity_name support appears to depend on apollo-api#21 (deal allowlist). To avoid this silently regressing for users who install an older qodev-apollo-api (e.g. 0.4.0), it may be worth bumping the minimum required version (and updating uv.lock) once the apollo-api release containing #21 is cut.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to apollo-api#21.
Fix
deals search --querynow maps toq_opportunity_name(searches the deal name). Apollo silently ignoresq_keywordson/opportunities/search, so this never actually filtered before. Verified e2e:--query NORRIQ→ 1, nonsense → 0.Skill (
SKILL.md+ references)person_senioritieslowercase enums,person_locations(country / 2-letter code / "City, State, Country"),organization_num_employees_ranges"min,max"(dash silently ignored), dict ranges,contact_email_statusvalues, canonicallinkedin_url, deal name search.deals createandpeople --keywords; removed the deletednewscommand; correctedjobs search→jobs list ACCOUNT_ID; clarified the deal--queryexample.Testing
ruff ✅ · mypy ✅ · 81 tests ✅ · e2e verified against the fixed api.
Depends on apollo-api#21 (adds
q_opportunity_nameto the deal allowlist). No version bump.🤖 Generated with Claude Code