qt-ui, qt-core: Merge qt-ui into qt-core#517
Conversation
benchoq
force-pushed
the
ben_0621_merge_ui
branch
5 times, most recently
from
e353a9c to
6cc086a
Compare
benchoq
force-pushed
the
ben_0621_merge_ui
branch
3 times, most recently
from
907dd6c to
62d1461
Compare
|
Generally, it works well. NIT: It would be quite good to click |
Both sugguestions look good. Will do it. thanks! |
benchoq
force-pushed
the
ben_0621_merge_ui
branch
2 times, most recently
from
8295976 to
6cfb5c8
Compare
This commit merges the code from qt-ui into qt-core. The custom editor has been reimplemented using Svelte to remove the dependency on the deprecated package `@vscode/webview-ui-toolkit`. The `openWidgetDesigner` command has been removed because it is outdated and its use case is unclear at the moment. For example, the current implementation does not look up available designers from the `additionalQtPaths` settings, nor does it consider the PySide virtual environment (venv or uv). A new command has been added to open the current file in the designer, matching the existing behavior for `.ts` files. When a `.ui` file is opened in the plain text editor, a button is shown in the editor tab to allow opening it in the designer. Log output has also been improved to make failures when opening the designer easier to understand. Task-number: [VSCODEEXT-263](https://qt-project.atlassian.net/browse/VSCODEEXT-263)
benchoq
force-pushed
the
ben_0621_merge_ui
branch
from
6cfb5c8 to
db334fa
Compare
|
@OrkunTokdemir Just finished reflecting your sugguestions. Please have it reviewed when you're available. :-) |
2 participants
This commit merges the code from qt-ui into qt-core. The custom editor has been reimplemented using Svelte to remove the dependency on the deprecated package
@vscode/webview-ui-toolkit.The
openWidgetDesignercommand has been removed because it is outdated and its use case is unclear at the moment. For example, the current implementation does not look up available designers from theadditionalQtPathssettings, nor does it consider the PySide virtual environment (venv or uv).A new command has been added to open the current file in the designer, matching the existing behavior for
.tsfiles. When a.uifile is opened in the plain text editor, a button is shown in the editor tab to allow opening it in the designer.Log output has also been improved to make failures when opening the designer easier to understand.
Task-number: VSCODEEXT-263