Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@OziEgri and @deanpoulos I lost access to my VPN but I will add here qua-programs files that can be run as a test with the simulator that you could run automatically as well as I will attach the enhanced waveform report |
|
|
||
|
|
||
| # === MAIN API === | ||
| def create_waveform_plot_with_markers( |
There was a problem hiding this comment.
With not just create_waveform_plot?
There was a problem hiding this comment.
I have many thoughts.
I was always in favor of moving the plotting to qualang_tools. But I don't want two tools, and I don't like the name enhanced waveform report.
We are one company, we need one product.
Let's name it Waveform Report and just improve it!
Hi @yomach I got some what you meant, a unified waveform report. Which one did you mean in terms of single + improve?
|
|
@KevinAVR - Good questions. |
Summary
Integrate the enhanced waveform report into qualang_tools as the new
qualang_tools.waveform_reportsubpackage (Alternative 1 from the plan).What was implemented:
qualang_tools/waveform_report/with__init__.pyre-exporting the public API andenhanced_report.pycontaining the implementation.VerticalMarkerConfig,TimingMarker,create_waveform_plot_with_markers,extract_timing_markers.waveform_reportadded toqualang_tools.__all__.tests/waveform_report/test_enhanced_waveform_report.pywith imports updated toqualang_tools.waveform_report.NOTE: Black got into the way of a few test files, but run all the regressions in the repository and passed. These are the important ones
Checklist:
tests/waveform_report/