Open
Conversation
- Add 10 experiment scripts (00a-09) for exchange-only qubit characterization - Use VoltageGateSequence from qualang_tools instead of local implementation - Add QDAC2 driver with set_qdac_voltage() helper - Add README documenting experimental setup and all scripts - Add 19 pure Python physics tests for SNR and macro utilities Tested against real hardware. DSL content validated.
Collaborator
|
@KevinAVR Any chance we can break this PR to smaller ones? |
Contributor
Author
@OziEgri definitely. I have broke it down into 5 PRs now. It is indeed a lot of code, I know it goes against the grain of what we are trying to do but it is an old tested code so it should work fine. even with 5 PRs it is still a few hundreds of lines of code each, but Physicist should be able to let it pass quickly with your permission (also @TheoLaudatQM ) may i add Sebastian and Kalid as reviewers as well? |
Collaborator
|
@KevinAVR got it, thanks! |
OziEgri
approved these changes
Jan 28, 2026
Contributor
Author
ok, even tho you approved this PR I'm breaking into 5 smaller ones right? just to confirm, I'm ok breaking into 5 PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Theo and Ozi, this PR contains the files that Dean and I used for EO qubits at LPS ~ 1.5 years ago. They were tested on the field, and they can act as a reference for the QCA folder.