Skip to content

Redesign/Node Parameters#230

Open
kleinwave wants to merge 5 commits intomainfrom
redesign/node-parameters
Open

Redesign/Node Parameters#230
kleinwave wants to merge 5 commits intomainfrom
redesign/node-parameters

Conversation

@kleinwave
Copy link
Copy Markdown
Collaborator

@kleinwave kleinwave self-assigned this Aug 3, 2025
@kleinwave kleinwave requested a review from manas-qm August 3, 2025 14:03
@kleinwave
Copy link
Copy Markdown
Collaborator Author

kleinwave commented Aug 3, 2025

figma:
Screenshot 2025-08-03 at 5 21 15 PM
before:
Screenshot 2025-08-03 at 5 26 52 PM

after:
Screenshot 2025-08-03 at 5 21 47 PM

edge case (tooltip hover with long parameter label):
Screenshot 2025-08-03 at 5 25 16 PM

how the same really long parameters look on the live version for comparison:
Screenshot 2025-08-03 at 5 30 34 PM

Same parameters are reused in graph library, so here’s the before and after to that as well:

before:
Screenshot 2025-08-03 at 6 07 07 PM

after:
Screenshot 2025-08-03 at 6 06 13 PM

@kleinwave
Copy link
Copy Markdown
Collaborator Author

kleinwave commented Aug 25, 2025

  • demonstrating updated click to edit parameters functionality
  • this works seemely in practice. You can click on it to edit and either click away, press enter, or ESC to exit edit mode. Try for yourself
  • one problem which hasn't been resolved yet is getting this to work with the refresh functionality. Because parameter values can be reset when the text box is modifiable, then either the refresh functionality needs to be reworked to accomadate this or the input wrappers still need to be modifiable stll somehow
Screenshot 2025-08-25 at 4 14 52 PM Screenshot 2025-08-25 at 4 15 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant