Better stream typings#179
Merged
Merged
Conversation
…F/JS Stream and Node's Readable interfaces
jacoscaz
force-pushed
the
better-stream-typings
branch
from
2256d12 to
e749977
Compare
…Node's own (and untyped) Readable class, slight refactor for enabling tests conditionally across different test suites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
StreamLikeinterface, which represents the common API surface that is shared by all the stream-like constructs that Quadstore must support:AsyncIteratorStreamReadableThis new interface is accompanied by a suite of unit tests focusing on ensuring its compatibility with the above.
With this new interface, this PR changes the following:
StreamLikeinterface, improving compatibility between the RDF/JS methods and the rest of Quadstore's API..match()method from the RDF/JSStoreinterface is now typed as anAsyncIterator, coherently with its actual type at run-time.Closes #178