iris-video-dlkm: downgrade uno-q to 1.0.4#36
iris-video-dlkm: downgrade uno-q to 1.0.4#36quaresmajose wants to merge 1 commit intoqualcomm-linux:mainfrom
Conversation
quaresmajose
force-pushed
the
iris-video-dlkm
branch
from
a86bc1e to
a20b57f
Compare
| @@ -0,0 +1,2 @@ | |||
| SRCREV:uno-q = "02248f4021f7690e675c408b4fd0208ad559a1d5" | |||
There was a problem hiding this comment.
this driver is not expected to support/work on agatti (the soc on unoq). i would rather disable it completely.
There was a problem hiding this comment.
but thanks for spotting/fixing the build issue though!
There was a problem hiding this comment.
I'll see if I can exclude it with COMPATIBLE_MACHINE, that way it would be removed from the world build.
There was a problem hiding this comment.
Is not just the world build and we also need to exclude the driver from qcom-multimedia-proprietary-image and qcom-container-orchestration-image.
There was a problem hiding this comment.
Maybe we should add the iris-video-dlkm to the MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS in meta-qcom/conf/machine/include/qcom-common.inc and stop making the installation explicit in the images. In this way, we could simply use COMPATIBLE_MACHINE here to disable the driver in UnoQ.
quaresmajose
force-pushed
the
iris-video-dlkm
branch
4 times, most recently
from
d158801 to
34a91e9
Compare
|
this is getting weird and complicated. how about we make the recipe in meta-qcom incompatible with 2290 soc (using SOC_FAMILY)? |
|
Can we raise SkipRecipe if |
|
The iris-video-dlkm is explicitly installed in qcom-multimedia-proprietary-image and because of this it needs to be available to all machines when they use the qcom distro. That's why I mentioned MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS in #36 (comment) |
Yes, that's also a possible solution. Especially since e.g. Talos will never be supported by the iris-video-dlkm. |
But we also want to bring dlkm recipes on the proprietary image only, so essential might not work. |
quaresmajose
force-pushed
the
iris-video-dlkm
branch
3 times, most recently
from
7413509 to
487cb6f
Compare
|
I've been experimenting with MACHINE_ESSENTIAL_EXTRA_RRECOMMENDS and MACHINE_EXTRA_RRECOMMENDS but without success so far. I think we should proceed with the downgrade to unlock the uno-q, and I will continue, and I will propose a different solution when I have something concrete. |
The iris-video-dlkm is currently broken in versions higher than 1.0.4 with the uno-q kernel linux-arduino 6.16. This driver is not expected to support/work on agatti (the soc on unoq). However, this iris-video-dlkm 1.0.4 hash is buildable, which allows maintaining a sane ci. Fixes qualcomm-linux#35 Signed-off-by: Jose Quaresma <jose.quaresma@oss.qualcomm.com>
quaresmajose
force-pushed
the
iris-video-dlkm
branch
from
487cb6f to
057b29c
Compare
I always forget which one is set only in packagegroup-base so impacts only certain images and is always a source of confusion for me. If this is always required, perhaps ESSENTIAL_RDEPENDS (instead of RRECOMMENDS) version would be better and would work. If it does not install for some reason, it will at least give an error. |
It's true, the concepts aren't easy to understand. The kernel module it's not always necessary and it's not even supported on some SoCs, but we have in COMPATIBLE_MACHINE they works on all arm64 which is not true. I'll come back to this when I have more time. |
5 participants
The iris-video-dlkm is currently broken with the uno-q kernel.
Fixes #35