Skip to content

pelt scheduler: add new tests to validate pelt#447

Open
vnarapar wants to merge 1 commit into
qualcomm-linux:mainfrom
vnarapar:pelt_scheduler
Open

pelt scheduler: add new tests to validate pelt#447
vnarapar wants to merge 1 commit into
qualcomm-linux:mainfrom
vnarapar:pelt_scheduler

Conversation

@vnarapar
Copy link
Copy Markdown
Contributor

@vnarapar vnarapar commented May 8, 2026

This PR adds new testcases to validate PELT scheduler

  • This validates configs, decay, load tracking, schedutil and different tunables

This PR adds new testcases to validate PELT scheduler
- This validates configs, decay, load tracking, schedutil and different
  tunables

Signed-off-by: Vamsee Narapareddi <vnarapar@qti.qualcomm.com>
@smuppand
Copy link
Copy Markdown
Contributor

smuppand commented May 8, 2026

@vnarapar please fix the workflow issues

Copy link
Copy Markdown
Contributor

@smuppand smuppand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are multiple files in the PR, I am providing a consolidated review.

  1. CI is failing for executable permissions and Shell Lint.
  2. All run.sh files use [ -z "$__INIT_ENV_LOADED" ]; please switch to ${__INIT_ENV_LOADED:-}.
  3. All run.sh files call check_dependencies but do not check the return value.
  4. PELT_decay Method 1 reads /proc/self/sched through grep, so it reads the grep process sched data instead of the shell workload. Please read /proc/$$/sched instead.
  5. PELT_sched_debug checks only whether /sys/kernel/debug exists, not whether debugfs is mounted. Please validate debugfs via /proc/mounts.
  6. PELT_schedutil uses -ge for “frequency increased”, making the equal-frequency warning path unreachable. Use -gt for increase and handle equality separately.
  7. Several scripts write .res and then exit 1. Please exit 0 after writing test FAIL/SKIP results so LAVA can publish the result cleanly.
  8. PELT_config still has copy-paste “DMA-BUF” log messages.
  9. Some tunables/sysfs entries are kernel-version/config dependent and should not be hard failures unless explicitly documented.
  10. YAMLs currently mask cd/run/send-to-lava failures with || true. Please remove unnecessary masking once run.sh result handling is fixed.

After these fixes and runtime evidence on at least one target, this can be reviewed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants