feat(sdk): support batched prompts in geniex-bench via --- separator#1159
Draft
RemiliaForever (RemiliaForever) wants to merge 1 commit into
Draft
feat(sdk): support batched prompts in geniex-bench via --- separator#1159RemiliaForever (RemiliaForever) wants to merge 1 commit into
RemiliaForever (RemiliaForever) wants to merge 1 commit into
Conversation
A --prompt-file may now hold multiple prompts separated by a line that is exactly `---`; each segment runs as its own prompt with the KV cache reset between segments, and stdout marks boundaries with `[sep ] prompt i/n`. A file without a `---` line stays a single prompt, so timing and --accuracy runs share one code path. Signed-off-by: RemiliaForever <remilia@koumakan.cc>
8baa0d4 to
11e099a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
geniex-bench's--prompt-filecan now hold multiple prompts in one file, separated by a line that is exactly---(leading/trailing whitespace on that line is ignored).----delimited segment runs as its own prompt, with the KV cache reset between segments (even under--no-reset-between-runs).[sep ] prompt i/nline (the previous[gen ]-prefixed header is gone, so it no longer collides with generated text).---line stays a single prompt, so timing and--accuracyruns share one code path — no branching on mode.---) are skipped; a file that is only separators errors out.Only
sdk/benchmark/benchmark.cchanges;benchmark.cis not a public SDK header, so no FFI update is required. Existing QDC entry scripts pass single prose prompt files with no---line, so their behavior is unchanged.Test plan
gcc -Wall -Wextracompiles and links cleanly againstpkg-geniexclang-format --Werrorclean---, back-to-back---, trailing---, no---(single prompt), multi-line segment, whitespace-padded---, only-separators (errors)