Conversation
Signed-off-by: Kushal Pal <kushpal@qti.qualcomm.com>
colmode
left a comment
colmode
left a comment
There was a problem hiding this comment.
Looks good overall, but we might want to merge this after erich's makefile changes rather than the other way around.
| r1 = #__boot_net_phys_offset__ | ||
| memw(r1) = r0 | ||
| jump _start // picolibc CRT entry (replaces hexagon_pre_main) | ||
|
|
There was a problem hiding this comment.
we can, but since we are not including any C header, we don't have __PICOLIBC__
so for simplicity I created 2 files
maybe I will have to use the PICOLIBC=1 flag to define a macro, which we can use
or do you have something else in mind?
There was a problem hiding this comment.
"PICOLIBC=1 flag to define a macro", yes. But since this is all transitional and we'll eventually use only pico I think that leaving it as is would be fine.
| r1 = #__boot_net_phys_offset__ | ||
| memw(r1) = r0 | ||
| jump _start // picolibc CRT entry (replaces hexagon_pre_main) | ||
|
|
There was a problem hiding this comment.
we can, but since we are not including any C header, we don't have __PICOLIBC__
so for simplicity I created 2 files
maybe I will have to use the PICOLIBC=1 flag to define a macro, which we can use
or do you have something else in mind?
thanks for the review, ping me whenever that is merged, I will have to resolve merge conflicts
sure, so far I have built H2 successfully and used the install artifacts to run Picolibc testsuite which passes |
Hey, look; our first comment from a non-qc account :) |
3 participants
No description provided.