fix: make CSS build output deterministic#20
Merged
Ryan Bower (R-Bower) merged 1 commit intoJun 5, 2026
Conversation
Signed-off-by: Olaf Kappes <okappes@qti.qualcomm.com>
Olaf (olaf-k)
force-pushed
the
olaf/fix/deterministic-css-build
branch
from
4e62986 to
9a99184
Compare
Ryan Bower (R-Bower)
approved these changes
Jun 5, 2026
Ryan Bower (R-Bower)
left a comment
Ryan Bower (R-Bower)
left a comment
Contributor
There was a problem hiding this comment.
Great find and fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR updates
build-cssto make its output predictable and stable over time.the current code aggregates files in the order they finish processing. this has two consequences:
the updated code aggregates files in alphabetical order, which resolves both cases.
note: this change is marked as
minorrather thanpatchbecause it modifies concatenation order of the bundle, which can affect rules with the same specificity. the only collision found was in menu and is addressed in qualcomm/qualcomm-ui#241edit: added tests