Build sdk as a dynamic library with -fPIC and release flags#37
Closed
fspindle wants to merge 1 commit intoqualisys:masterfrom
Closed
Build sdk as a dynamic library with -fPIC and release flags#37fspindle wants to merge 1 commit intoqualisys:masterfrom
fspindle wants to merge 1 commit intoqualisys:masterfrom
Conversation
MaximilienNaveau
left a comment
MaximilienNaveau
left a comment
There was a problem hiding this comment.
Hi,
I made some suggestion to you PR to improve it.
Comment on lines
+9
to
+14
| if(UNIX) | ||
| if(CMAKE_COMPILER_IS_GNUCXX OR CV_ICC) | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") | ||
| endif() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
The CMake equivalent of adding -fPIC is CMAKE_POSITION_INDEPENDENT_CODE
So it should be more like this:
Suggested change
| if(UNIX) | |
| if(CMAKE_COMPILER_IS_GNUCXX OR CV_ICC) | |
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") | |
| endif() | |
| endif() | |
| if(SUFFIX_SO_VERSION) | |
| option(CMAKE_POSITION_INDEPENDENT_CODE "Use position independent code" ON) | |
| endif() |
| if(NOT CMAKE_BUILD_TYPE) | ||
| set(CMAKE_BUILD_TYPE "Release" CACHE STRING "Choose the type of build, options are: None Debug Release RelWithDebInfo MinSizeRel." FORCE) | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Instead of adding and forcing the compilation of the shared library you can simply add
Suggested change
| option(SUFFIX_SO_VERSION "Suffix library name with its version" ON) |
See suggestion below for the deletion of the SHARED parameter.
| option(BUILD_EXAMPLES "Build examples" OFF) | ||
|
|
||
| add_library(${PROJECT_NAME} | ||
| SHARED |
There was a problem hiding this comment.
This above suggestions
Suggested change
| SHARED |
Contributor
|
This has now been fixed in PR #113. Thanks for the feedback! :) Feel free to check it out and let us know if we missed something. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.