Merged
Conversation
Capelliexp
reviewed
Jan 28, 2025
Closed
MaximilienNaveau
approved these changes
Feb 20, 2025
Capelliexp
approved these changes
Feb 20, 2025
OliverGlandberger
force-pushed
the
fix_installation_paths
branch
from
36712aa to
1f3dc79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The author jgoppert originally posted the following description in THIS PR:
"GNUInstallDirs was not defined when target_include_directories was set. This caused it to be blank and the cmake target import failed. User projects importing the cmake target should use include qualisys_cpp_sdk/RTProtocol.h etc."
This PR implements the changes suggested by jgoppert.
NOTE: It seems 'GNUInstallDirs' somehow snuck its way into master early.
Tests Run: