Skip to content

fix: sitewide accessibility — nav labels, table scope, aria-live, tablist, SVG#3249

Merged
OAGr merged 1 commit intomainfrom
claude/fix-p2-accessibility
Mar 26, 2026
Merged

fix: sitewide accessibility — nav labels, table scope, aria-live, tablist, SVG#3249
OAGr merged 1 commit intomainfrom
claude/fix-p2-accessibility

Conversation

@OAGr
Copy link
Copy Markdown
Contributor

@OAGr OAGr commented Mar 26, 2026

Summary

Fixes 6 P2 accessibility bugs from QA sweep (Discussion #3220):

  • Bug 65: Added aria-label to all <nav> elements (Main navigation, Breadcrumb)
  • Bug 66: Added scope="col" to all <th> via SortHeader + non-sortable headers; added <caption className="sr-only"> to orgs/ai-models/people tables
  • Bug 67: Added role="status" + aria-live="polite" to loading indicators in orgs/people tables
  • Bug 68: Added aria-label to ProfileTabs tablist ("Organization sections", "Person sections", "Legislation sections")
  • Bug 69: Added dynamic aria-label to "View all →" links on homepage
  • Bug 72: Added aria-hidden="true" to decorative SVG icons in nav/mobile menu

13 files changed, 35 insertions, 18 deletions.

Test plan

  • All tests pass
  • Changes are additive ARIA attributes — no visual or behavioral changes

🤖 Generated with Claude Code

…live, tablist labels, aria-hidden

Bug 65: Add aria-label="Main navigation" to layout nav, aria-label="Breadcrumb" to
directory/Breadcrumbs.tsx (wiki Breadcrumbs.tsx already had it).

Bug 66: Add scope="col" to all <th> elements — SortHeader component covers sortable
headers; standalone <th> elements in organizations-table get explicit scope. Add
sr-only <caption> to organizations, ai-models, and people tables.

Bug 67: Add role="status" aria-live="polite" to loading state <td> cells in
organizations-table and people-table so screen readers announce loading changes.

Bug 68: Add aria-label prop to ProfileTabs component (passed through to TabsList).
Apply "Organization sections", "Person sections", and "Legislation sections" labels
on respective detail pages. Default fallback is "Page sections".

Bug 69: Add aria-label to "View all →" links on homepage — dynamic per section
(e.g. "View all Organizations") and static "View all wiki pages" for recently updated.

Bug 72: Add aria-hidden="true" to decorative SVG icons in layout (RSS feed icon),
MobileNav (hamburger/close icons), and NavDropdown (chevron icon).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 26, 2026

Warning

Rate limit exceeded

@OAGr has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 51 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 98e09dd3-b4e5-4559-9955-d04d32f8be0f

📥 Commits

Reviewing files that changed from the base of the PR and between 8b8627c and 7dd5f4d.

📒 Files selected for processing (13)
  • apps/web/src/app/ai-models/ai-models-table.tsx
  • apps/web/src/app/layout.tsx
  • apps/web/src/app/legislation/[slug]/page.tsx
  • apps/web/src/app/organizations/[slug]/page.tsx
  • apps/web/src/app/organizations/organizations-table.tsx
  • apps/web/src/app/page.tsx
  • apps/web/src/app/people/[slug]/page.tsx
  • apps/web/src/app/people/people-table.tsx
  • apps/web/src/components/MobileNav.tsx
  • apps/web/src/components/NavDropdown.tsx
  • apps/web/src/components/directory/Breadcrumbs.tsx
  • apps/web/src/components/directory/ProfileTabs.tsx
  • apps/web/src/components/directory/SortHeader.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-p2-accessibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Test Coverage Report

Workspace Lines Branches Functions Statements
wiki-server 50.8% 34.2% 47.2% 49.4%
web 9.5% 7.7% 5.5% 9.4%
discord-bot 39.4% 30.5% 44.1% 38.4%
crux 27.0% 24.2% 30.3% 27.1%
Total 24.9% 18.8% 20.9% 24.6%

Coverage is advisory only — no thresholds enforced. Generated by vitest --coverage.

@OAGr OAGr added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit c2ae8e6 Mar 26, 2026
21 of 22 checks passed
@OAGr OAGr deleted the claude/fix-p2-accessibility branch March 26, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant