Open
Conversation
…ge that is still work in progress
Merge readthe docs changes into my training documentation branch
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the training documentation and correct the dropout behavior in the Embedder Model by setting the dropout rate to 0.7 during instantiation.
- Updates the dropout parameter when creating the EmbeddingModel instance
- Improves documentation regarding the dropout change in eval mode
Files not reviewed (3)
- README.rst: Language not supported
- docs/source/index.rst: Language not supported
- docs/source/training.rst: Language not supported
Comments suppressed due to low confidence (1)
paule/paule.py:165
- Consider adding test cases to verify that the new dropout parameter behaves as expected in eval mode.
self.embedder = EmbeddingModel(num_lstm_layers=2, hidden_size=720, dropout=0.7).double()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a little to the documentation and also puts the dropout to 0.7 in the Embedder Model so that Dropout is corrected in the .eval mode of the mode.
It is currently untested if this works