Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Seven new values were added to Property.PropertyType, but ElasticIndexMappingsFactory still only enumerates STRING, DATE and DECIMAL in TYPES_MAP and KINDS_MAP. When a library defines a property with any of the new kinds (e.g. BINARY or HTML), ElasticsearchMoleculesResourceAllocator will look up the Elasticsearch type using this map and format a mapping with "type": "null", which Elasticsearch rejects. Likewise, property-type discovery from existing indices will return null because KINDS_MAP has no entries for the new kinds. As written, the extended types cannot be indexed or read back from Elasticsearch.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cqp-build/src/main/kotlin/com/quantori/cqp/build/CqpJavaLibraryPlugin.kt
Show resolved
Hide resolved
96a37f8 to
20932a0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cqp-build/src/main/kotlin/com/quantori/cqp/build/CqpJavaLibraryPlugin.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cqp-build/src/main/kotlin/com/quantori/cqp/build/CqpJavaLibraryPlugin.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cqp-build/src/main/kotlin/com/quantori/cqp/build/CqpJavaLibraryPlugin.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
...search/src/main/java/com/quantori/cqp/storage/elasticsearch/ElasticIndexMappingsFactory.java
Show resolved
Hide resolved
|
@codex can you approve this? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cqp-build/src/main/kotlin/com/quantori/cqp/build/CqpJavaLibraryPlugin.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
💡 Codex Review
Equality/inequality filters for property values now route all non-STRING types through a term query (ElasticsearchStorageMolecules.java:354-357). The newly added types such as BINARY, HYPERLINK, CHEMICAL_STRUCTURE, STRUCTURE_3D, and HTML are mapped to Elasticsearch binary or analyzed text variants (match_only_text, text, search_as_you_type; see ElasticIndexMappingsFactory.java:29-42), so a term query either triggers a runtime error (binary fields are not indexed) or bypasses analysis and returns no hits. Any search using the new types with EQUAL/NOT_EQUAL will therefore fail or silently misbehave. Adjust the query construction or mappings so these new types use supported search semantics (or are rejected) instead of a raw term query.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Description:
Issue Link:
Closes #N/A (architecture-planning data-types Task 0.1)
Testing:
cd chem-query-platform && GRADLE_USER_HOME=.gradle-home ./gradlew :cqp-api:testcd chem-query-platform && GRADLE_USER_HOME=.gradle-home ./gradlew :cqp-api:publishToMavenLocal