fix(preview): relative iframe src for subpath deployment (bd-0pm7a)#226
Merged
Conversation
Q2DebugIframe and Q2PreviewIframe hard-coded `src="/q2-*.html"`, which is root-absolute and bypasses Vite's `base: './'`. Locally and in Playwright the SPA is served at the host root so the two coincide; under a subpath deployment the iframe requested `https://host/q2-*.html` and got the platform's 404 / SPA shell, blanking the preview. Dropping the leading slash resolves the iframe against the parent doc's pathname, matching how the rest of the build references its assets. Hash-only routing keeps the parent's pathname stable across client navigation, so the relative form is correct at every route.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes bd-0pm7a.
Q2DebugIframeandQ2PreviewIframehard-codedsrc="/q2-*.html", which is root-absolute and bypasses Vite'sbase: './'.Locally and under Playwright the SPA is served at the host root so the two coincide; under a subpath deployment the iframe requested
https://host/q2-*.htmland got the platform's 404 / SPA shell, leaving the preview blank.Dropping the leading slash resolves the iframe against the parent doc's pathname, matching how the rest of the build references its assets. Hash-only routing (
hub-client/src/utils/routing.ts) keeps the parent pathname stable across client navigation, so the relative form is correct at every route.Verified locally by serving
hub-client/dist/under a/app/subpath.