hub-client: simplify the per-keystroke attribution update#237
Merged
Conversation
…path updateRunListAttribution was iterating handle.history() to decide which changes to replay, even though getChanges(workDoc, doc) already returns exactly the new changes in causal order. The history walk added an O(N) topoHistoryTraversal call per debounce cycle (N = total changes in the doc) plus K decodeHeads + Map lookups, all to recompute information getChanges already provides. processedHeads / processedHistoryIndex remain in the state for the cold-start path's contract but are now pure bookkeeping in the incremental path. Adds an invariant test: incremental update must equal a from-scratch buildRunListAttribution on the merged final doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getChangesAPI already returns exactly that list — only the new changes, in the right order — in a single call. This PR uses it directly and drops the history scan.