Add a new regexp to also match uri in the form /proxy/{{port}} - #14596
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cderv
left a comment
There was a problem hiding this comment.
Thanks for the fix.
The new pattern looks right for code-server — /proxy/{port}/ and /absproxy/{port}/ are both valid code-server proxy URL formats, so matching both with (?:abs)? makes sense.
I want to get sign-off from the Positron team before merging, since this area has known interactions with the VS Code extension (@cscheid flagged this in the issue).
For reference from what I found:
- Positron doesn't use
VSCODE_PROXY_URI— it builds its own proxy — and its format is also/proxy/{port}/on desktop, so the new pattern covers it correctly.
The Workbench path (/p/{token}/) was already matched by the first regex.
No regression expected, but they should still be aware of the change.
@vezwork asking you for the Quarto VSCODE extension in case you see anything. And do you know who is best fit in positron team to ask ? I'll probably slack them.
|
I don't see anything obvious, I don't see how this could cause issues. Probably @juliasilge is the best person I know to ask. |
|
Here is my understanding of what is going with this fix: Posit Workbench (Positron Pro / VS Code sessions) should be unaffectedWorkbench reverse-proxies sessions under a Positron Desktop should be unaffectedIn the desktop app, Positron Server Web (like in JupyterHub) is newly matched, and likely a fix!Here Positron forwards previews through its own proxy and produces external URLs of the form I don't know if we have the ability to test this in Positron Server on JupyterHub before merging (a pretty high lift) so I think we should go for it and look for any regressions. We do have some automated testing on the Positron side for JupyterHub. cc @testlabauto and @isabelizimm for visibility on this upcoming change to the Quarto CLI, which I believe would fix problems with |
|
Thank you ! I will merge this and make a new 1.10 build so you can test. We're not close to release 1.10 so we have time to revert or adapt. |
closes #14595
Description
This PR add a pattern to match, used with the preview subcommand to reload the page
Checklist
I have (if applicable):