Skip to content

Fix argument name for MLflow server to use --artifacts-destination#6

Merged
vstirbu merged 2 commits intomainfrom
5-start-the-server-with-artifact-serving
May 12, 2025
Merged

Fix argument name for MLflow server to use --artifacts-destination#6
vstirbu merged 2 commits intomainfrom
5-start-the-server-with-artifact-serving

Conversation

@vstirbu
Copy link
Contributor

@vstirbu vstirbu commented May 12, 2025

No description provided.

@vstirbu vstirbu linked an issue May 12, 2025 that may be closed by this pull request
@vstirbu vstirbu requested review from MaheeGamage and Copilot May 12, 2025 09:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MLflow server startup script to use the correct argument name for specifying the artifacts destination.

  • The script replaces --default-artifact-root with --artifacts-destination.
  • The change reflects an update in the MLflow server argument, aligning with the intended configuration.
Comments suppressed due to low confidence (1)

mlflow/entrypoint.sh:14

  • [nitpick] The environment variable name MLFLOW_DEFAULT_ARTIFACT_ROOT remains unchanged even though the argument flag has been updated to '--artifacts-destination'. Consider renaming the environment variable for improved clarity and consistency with the new flag.
+    --artifacts-destination "$MLFLOW_DEFAULT_ARTIFACT_ROOT" \

@vstirbu vstirbu requested a review from Copilot May 12, 2025 10:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the argument name for the MLflow server to use the updated parameter "--artifacts-destination," ensuring consistency between the environment variable and the CLI option.

  • Renames the environment variable from MLFLOW_DEFAULT_ARTIFACT_ROOT to MLFLOW_DEFAULT_ARTIFACTS_DESTINATION.
  • Updates the server's CLI argument from --default-artifact-root to --artifacts-destination.
Comments suppressed due to low confidence (2)

mlflow/entrypoint.sh:8

  • Ensure that the new environment variable name is updated in all related documentation and usage references to maintain consistency with the new CLI argument.
MLFLOW_DEFAULT_ARTIFACTS_DESTINATION="${MLFLOW_DEFAULT_ARTIFACTS_DESTINATION:-s3://mlflow}"

mlflow/entrypoint.sh:14

  • Confirm that the new CLI argument '--artifacts-destination' aligns with MLflow's updated interface and that any dependent scripts or configurations are adjusted accordingly.
--artifacts-destination "$MLFLOW_DEFAULT_ARTIFACTS_DESTINATION" \

@vstirbu vstirbu merged commit 230eed2 into main May 12, 2025
1 check passed
@vstirbu vstirbu deleted the 5-start-the-server-with-artifact-serving branch May 12, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Start the server with artifact serving

3 participants