Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MLflow server startup script to use the correct argument name for specifying the artifacts destination.
- The script replaces --default-artifact-root with --artifacts-destination.
- The change reflects an update in the MLflow server argument, aligning with the intended configuration.
Comments suppressed due to low confidence (1)
mlflow/entrypoint.sh:14
- [nitpick] The environment variable name MLFLOW_DEFAULT_ARTIFACT_ROOT remains unchanged even though the argument flag has been updated to '--artifacts-destination'. Consider renaming the environment variable for improved clarity and consistency with the new flag.
+ --artifacts-destination "$MLFLOW_DEFAULT_ARTIFACT_ROOT" \
MaheeGamage
approved these changes
May 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the argument name for the MLflow server to use the updated parameter "--artifacts-destination," ensuring consistency between the environment variable and the CLI option.
- Renames the environment variable from MLFLOW_DEFAULT_ARTIFACT_ROOT to MLFLOW_DEFAULT_ARTIFACTS_DESTINATION.
- Updates the server's CLI argument from --default-artifact-root to --artifacts-destination.
Comments suppressed due to low confidence (2)
mlflow/entrypoint.sh:8
- Ensure that the new environment variable name is updated in all related documentation and usage references to maintain consistency with the new CLI argument.
MLFLOW_DEFAULT_ARTIFACTS_DESTINATION="${MLFLOW_DEFAULT_ARTIFACTS_DESTINATION:-s3://mlflow}"
mlflow/entrypoint.sh:14
- Confirm that the new CLI argument '--artifacts-destination' aligns with MLflow's updated interface and that any dependent scripts or configurations are adjusted accordingly.
--artifacts-destination "$MLFLOW_DEFAULT_ARTIFACTS_DESTINATION" \
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.