Skip to content

chore(qwp): quiet only test-only drainer setup-failure log noise #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluestreak01 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

chore(qwp): quiet only test-only drainer setup-failure log noise #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion core/src/main/java/io/questdb/client/cutlass/qwp/client/sf/cursor/BackgroundDrainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,18 @@ public void run() {
outcome = DrainOutcome.STOPPED;
} catch (Throwable t) {
String msg = t.getMessage();
LOG.error("drainer setup failed for slot {}: {}", slotPath, msg, t);
if (slotPath != null) {
// Real orphan slot: a setup failure means unacked data on disk
// could not be drained to the server -- a durability concern
// that stays at ERROR so operators see it.
LOG.error("drainer setup failed for slot {}: {}", slotPath, msg, t);
} else if (LOG.isDebugEnabled()) {
// Only @TestOnly drainers carry a null slot (zero segment size);
// they fast-fail by design and would otherwise flood CI logs.
// The isDebugEnabled() guard avoids the varargs array and the
// message formatting when DEBUG is off, so it makes no garbage.
LOG.debug("drainer setup failed for slot {}: {}", slotPath, msg, t);
}
lastErrorMessage = msg;
try {
OrphanScanner.markFailed(slotPath, "setup: " + msg);
Expand Down
Loading