Add token-conformance scan to design-qa skill - #10
Merged
Conversation
Second embedded primitive: learns the repo's design tokens at runtime by probing every :root CSS variable through a throwaway element (var(--x) applied to background-color/box-shadow/border-radius), so it works on any CSS-variable design system with no per-stack config and sidesteps text-format mismatches. Flags off-palette colors (RGB distance), off-token box-shadows, and off-token border-radii. Spacing is intentionally checked only against a real scale, not a generic 4px heuristic (that was the loudest false-positive source when dogfooding on the board viewer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second embedded primitive for
agent-board-design-qa(iteration 2). Where the geometry scan asks "is it broken", the token scan asks "is it off-system".:rootCSS variable through a throwaway element (var(--x)applied tobackground-color/box-shadow/border-radius, keep whatever computes). No per-stack config; works on any CSS-variable design system; sidesteps the text-format mismatch where a token shadow and a rendered shadow never compare equal as strings.Dogfooded on the
agent-board webviewer: detected 26 color / 3 radius / 1 shadow tokens, found 3 real off-token box-shadows (bespoke inset highlights on the selects + refresh button), zero color/radius false positives.Types + drift + 67 tests green.
🤖 Generated with Claude Code