feat: add qprobe design command for deterministic UI design QA - #4
Merged
Conversation
Launches headless Chromium and, per --viewport, runs a DOM geometry scan plus a CSS-variable token-conformance scan, printing JSON findings. The scanners are shared verbatim with the agent-board design-qa skill (one source of truth). Browser-launch is dogfooded; CI keeps a routing test since the bare runner has no Chromium.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
qprobe design <url>— measure the rendered UI for layout and design-token defects, deterministically and without a vision model.--viewport, runs a DOM geometry scan (overflow, truncation, collapse, sibling overlap, near-miss misalignment, tap targets, sub-16px input fonts) and a CSS-variable token-conformance scan (off-palette colors, off-token box-shadows, off-token border-radii). Prints JSON findings.:rootCSS variable through a throwaway element — no per-stack config, works on any CSS-variable design system, and sidesteps the text-format mismatch where a token shadow and a rendered shadow never compare equal as strings.agent-board-design-qaskill (one source of truth).Dogfooded against a live app: 36 findings across two viewports (12 blocking overflow @375, off-token shadows, small tap targets), zero color/radius false positives. Typecheck + build + 213 unit tests + a CI-safe routing test green. Browser-launch isn't exercised in CI (no Chromium on the bare runner).
Changeset included (minor bump).
🤖 Generated with Claude Code