feat(0406): Add Gemma4 Unified vision-language support#1036
Open
vbaddi wants to merge 3 commits into
Open
Conversation
Add QEff wrappers and transform wiring for Gemma4 Unified text and conditional-generation models. This adds encoder-free vision embedding support, Gemma4 Unified cache/mask handling for mixed sliding/full attention, dual-QPC export helpers, prefill chunking lens fixes, and dummy parity/ONNX quickcheck coverage. Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
Signed-off-by: vbaddi <vbaddi@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vision_config.num_soft_tokensfor Gemma4 Unified vision token sizing.Vision Model Note
Gemma4 Unified changes the vision path from the older heavy vision tower style to a lightweight/encoder-free image embedding path: image patches are embedded through
embed_vision, then inserted into the language stream as soft vision tokens. The full model config usesnum_soft_tokens=280, so export/runtime now size the retained vision embeddings from that value instead of falling back to older defaults. This matches the model behavior described in the Gemma4 visual guide context (newsletter.maartengrootendorst.com)Validation
QEFF_CTX_LEN=2048,QEFF_PREFILL_SEQ_LEN=128, andQEFF_GENERATION_LEN=64.cc: @anujgupt-github @quic-hemagnih @tchawada