[EB] Qwen_3_5_Moe#1038
Open
mohiso22 wants to merge 4 commits into
Open
Conversation
added 2 commits
June 4, 2026 18:15
Signed-off-by: Mohit Soni <mohisoni@qti.qualcomm.com>
Signed-off-by: Mohit Soni <mohisoni@qti.qualcomm.com>
vbaddi
requested changes
Jun 4, 2026
| packed_chunk_size=EXPERT_BLOCKING_PACKED_CHUNK_SIZE, | ||
| packed_chunk_size=packed_chunk_size, | ||
| ) | ||
| return experts_out.sum(dim=0) |
Contributor
There was a problem hiding this comment.
nit: w/subf tested? this needs einsum fix too.
Contributor
Author
There was a problem hiding this comment.
yup it needs that, will fix
| # attn[..., i, :i] = row + (row.unsqueeze(-1) * sub).sum(-2) | ||
| attn[..., i, :i] = row + torch.einsum("bghi,bghij->bghj", row, sub) | ||
| attn = attn + torch.eye(chunk_size, dtype=attn.dtype, device=attn.device) | ||
| # for i in range(1, chunk_size): |
| self.gate_up_proj_w = self.experts.gate_up_proj | ||
| self.down_proj_w = self.experts.down_proj | ||
|
|
||
| def _split_expert_weights(self, hidden_size: int): |
Contributor
There was a problem hiding this comment.
nit: this can be done once during init, can remove from forward
Signed-off-by: Mohit Soni <mohisoni@qti.qualcomm.com>
Signed-off-by: Mohit Soni <mohisoni@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.