Skip to content

Add on-device sampling support for Qwen3VL Dense#934

Merged
quic-hemagnih merged 3 commits into
quic:release/v1.21.6from
quic-xiyushi:ods-qwen3vl
Apr 23, 2026
Merged

Add on-device sampling support for Qwen3VL Dense#934
quic-hemagnih merged 3 commits into
quic:release/v1.21.6from
quic-xiyushi:ods-qwen3vl

Conversation

@quic-xiyushi
Copy link
Copy Markdown
Contributor

@quic-xiyushi quic-xiyushi commented Apr 21, 2026

This PR enables on-device sampling for Qwen3‑VL Dense.

  • The on-device sampling infrastructure is generic, but new models must be registered in SamplerTransform.
  • Qwen3‑VL Dense introduces deepstack features that were not part of previously supported model inputs/outputs.
  • This PR updates the sampler transform to correctly handle those deepstack features.

These changes make Qwen3‑VL Dense compatible with on-device sampling.

Signed-off-by: quic-xiyushi <xiyushi@qti.qualcomm.com>
Signed-off-by: quic-xiyushi <xiyushi@qti.qualcomm.com>
@vbaddi
Copy link
Copy Markdown
Contributor

vbaddi commented Apr 21, 2026

@quic-xiyushi Can we pls add a test case for this, thanks

Signed-off-by: quic-xiyushi <xiyushi@qti.qualcomm.com>
@quic-xiyushi
Copy link
Copy Markdown
Contributor Author

@vbaddi , done, I have added a test case for qwen3vl dense with on-device sampling. Thanks!

@quic-xiyushi
Copy link
Copy Markdown
Contributor Author

@vbaddi , this change should go into both the main branch and the release/v1.21.6 branch. Do I need to create two PRs for that?

@vbaddi
Copy link
Copy Markdown
Contributor

vbaddi commented Apr 22, 2026

@vbaddi , this change should go into both the main branch and the release/v1.21.6 branch. Do I need to create two PRs for that?

yes, we would need it on both release and main branch too.
++ @quic-rishinr

@quic-hemagnih quic-hemagnih merged commit 0ef580c into quic:release/v1.21.6 Apr 23, 2026
4 checks passed
@quic-hemagnih
Copy link
Copy Markdown
Contributor

@quic-xiyushi please raise a PR for main branch also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants