Add on-device sampling support for Qwen3VL Dense#934
Merged
Conversation
Signed-off-by: quic-xiyushi <xiyushi@qti.qualcomm.com>
Signed-off-by: quic-xiyushi <xiyushi@qti.qualcomm.com>
Contributor
|
@quic-xiyushi Can we pls add a test case for this, thanks |
Signed-off-by: quic-xiyushi <xiyushi@qti.qualcomm.com>
Contributor
Author
|
@vbaddi , done, I have added a test case for qwen3vl dense with on-device sampling. Thanks! |
Contributor
Author
|
@vbaddi , this change should go into both the main branch and the release/v1.21.6 branch. Do I need to create two PRs for that? |
Contributor
yes, we would need it on both release and main branch too. |
vbaddi
approved these changes
Apr 22, 2026
quic-hemagnih
approved these changes
Apr 23, 2026
Contributor
|
@quic-xiyushi please raise a PR for main branch also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables on-device sampling for Qwen3‑VL Dense.
These changes make Qwen3‑VL Dense compatible with on-device sampling.