Conversation
…bles - Replace all hardcoded "owner"/"users"/"guests" strings with dynamic seed_config.py lookups throughout scripts/ - Remove _ensure_projects from sagemaker_gaps.py — Terraform owns project creation; project IDs now read from tf-outputs.json via project.project_name - Move Glue data source logic (_ensure_glue_data_source and helpers) from sagemaker_gaps.py into seed_glue_tables.py where it belongs - seed_glue_tables.py uses SEED_CONFIG.default_project for owner and non-default projects for subscribers — no hardcoded keys anywhere Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…outputs.json Terraform was removing DATAZONE_PROJECTS from the control-plane and rale-authorizer Lambdas on every apply because the key wasn't in the config, then sagemaker_gaps.py would re-add it via direct boto3 calls — an infinite back-and-forth. Fix: declare `var.datazone_projects` (default "") and wire it into both Lambda environment blocks. The _terraform-apply task now reads the value from infra/tf-outputs.json (written by sagemaker_gaps.py on the previous run) and passes it as TF_VAR_datazone_projects, so Terraform owns the key and plans no changes on subsequent deploys. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seed_glue_tables.pyscript provisions Glue databases, registers S3 locations with LF, creates Iceberg tables, and drives the DataZone Glue import flowDATAZONE_PROJECTSis now declared in Terraform and fed back viatf-outputs.json, eliminating post-domain-recreation driftseed-config.yaml(no more hardcoded names)Test plan
./poe deploycompletes cleanly (Terraform plan shows only expected LF/Glue additions)python scripts/seed_glue_tables.pyseeds databases and tables without errorpython scripts/seed_users.pyandseed_packages.pyrun without referencing hardcoded project names./poe test-unitpasses🤖 Generated with Claude Code