Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See Issue #1702. This fix has been implemented in 3 commits so that the first 2 commits can be safely cherry-picked to stable. Alongside the MyETM changes, this should resolve the issues with user syncing, however two other minor changes are needed on stable in the old scenario updater to fully enable the changes:
copy_preset_roles block (around line 59)
This represents a divergence between stable and pro, necessary because of the changes to the scenario updater.
Implementation details
Because MyETM calls: PUT /api/v3/scenarios/:id in the saved scenario callbacks, the ScenarioUpdater handles the request and therefore needs to handle the
saved_scenario_usersparam, otherwise it will silently be dropped.Testing
See testing details in the MyETM PR
Related Issues
See this MyETM Issue
Goes with this MyETM PR
Closes #1702