Redesign Buildings solar thermal slider#3263
Open
kaskranenburgQ wants to merge 1 commit intomasterfrom
Open
Conversation
This was referenced May 12, 2025
|
This pull request has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future. |
github-actions
bot
added
the
Stale
kndehaan
added
Pinned
kaskranenburgQ
force-pushed
the
buildings-solar-thermal
branch
from
209d5c1 to
5092a03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes quintel/etmodel#4477
In the previous modelling, the solar thermal sliders could provide for a maximum of 13% of the building heating demand.
This maximum was not documented, and hardcoded in the slider settings.
As indicated in the issue this was not correctly shown in the front-end as well.
Goes together with:
quintel/etmodel#4489
quintel/etengine#1581