Add macOS PATH setup for CLI launchers#36
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb0699821f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
t-kalinowski
force-pushed
the
fix-macos-local-bin-path
branch
from
eb06998 to
f7b5be8
Compare
t-kalinowski
force-pushed
the
fix-macos-local-bin-path
branch
from
f7b5be8 to
bca2686
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bca2686c0b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
This fixes the macOS launcher installation path for users whose shell does not already include
~/.local/bin. macOS does not add that directory toPATHby default, so launchers created there can be invisible until users edit their shell startup files manually.Closes #35
User-facing changes
install_pkg_cli_apps()now adds the default~/.local/bininstall directory to~/.zprofileon macOS when it is not already present onPATH.source ~/.zprofile.RAPP_NO_MODIFY_PATH=1continues to opt out of PATH modification.Internal changes
PATHafter adding the macOS install directory, so subprocesses from the same R session can find installed launchers..zprofile, avoiding duplicate writes, skipping whenPATHalready includes the install directory, and respectingRAPP_NO_MODIFY_PATH.