Skip to content

Fix Windows PATH handling for launcher installs#38

Merged
t-kalinowski merged 5 commits into
mainfrom
fix-windows-path-error
Jun 11, 2026
Merged

Fix Windows PATH handling for launcher installs#38
t-kalinowski merged 5 commits into
mainfrom
fix-windows-path-error

Conversation

@t-kalinowski

@t-kalinowski t-kalinowski commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Persist launcher directories in the Windows user-level Path even when they are already present only in the live process PATH, without clobbering that live PATH
  • Use a short Windows path when available, with duplicate checks against both canonical and short forms
  • Add a clearer guard and user hint for the 32767-character PATH limit
  • Exclude .git from source builds so local worktree metadata does not show up in package checks
  • Document the Windows PATH handling fix in NEWS.md for Fix Windows PATH handling for launcher installs #38

Testing

  • testthat::test_local() passed
  • R CMD build . passed
  • R CMD check --no-manual Rapp_0.3.0.9000.tar.gz passed

@t-kalinowski t-kalinowski marked this pull request as ready for review June 11, 2026 13:37

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 92f3831199

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread R/install.R Outdated
@t-kalinowski t-kalinowski merged commit f094971 into main Jun 11, 2026
5 checks passed
@t-kalinowski t-kalinowski deleted the fix-windows-path-error branch June 11, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant