Support impersonated ADC credentials#311
Open
botan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #266. Adds support for application default credentials with
type = "impersonated_service_account".When
credentials_app_default()sees this ADC format, gargle now uses the nestedauthorized_usercredentials to obtain a source token and exchanges that token against the IAM Credentials API to mint an impersonated access token. It also stops silently falling through for unknown ADC types and emits a debug message instead.Also updates
token_tokeninfo()so this token class is treated like the existing nonstandard refreshable token types.Tests cover the new impersonated ADC flow, default scope behavior, unsupported source credential types, and the unsupported-ADC debug path.