Skip to content

Implement "auto" r_version value in backport_linter()#2907

Draft
Bisaloo wants to merge 8 commits into
mainfrom
auto-version-backport-linter
Draft

Implement "auto" r_version value in backport_linter()#2907
Bisaloo wants to merge 8 commits into
mainfrom
auto-version-backport-linter

Conversation

@Bisaloo

@Bisaloo Bisaloo commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

Opening as a draft for a first general impression.

If this seems good, I still need to:

  • Add a NEWS.md item
  • Add tests

Should this be the new default value for backport_linter(r_version=)?

Fix #1974.

@codecov

codecov Bot commented Jul 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.18%. Comparing base (dc8f149) to head (27bf933).

Files with missing lines Patch % Lines
R/settings_utils.R 0.00% 6 Missing ⚠️
R/backport_linter.R 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2907      +/-   ##
==========================================
- Coverage   99.28%   99.18%   -0.10%     
==========================================
  Files         128      128              
  Lines        7231     7239       +8     
==========================================
+ Hits         7179     7180       +1     
- Misses         52       59       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread R/settings_utils.R Outdated
@MichaelChirico

Copy link
Copy Markdown
Collaborator

Holding off on review since I see draft & red tests. Please ping if you're looking for early feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make backport_linter() more informative by default

3 participants