Relax package path assumptions in download_version_url#441
Open
martinstuder wants to merge 2 commits intor-lib:mainfrom
Open
Relax package path assumptions in download_version_url#441martinstuder wants to merge 2 commits intor-lib:mainfrom
martinstuder wants to merge 2 commits intor-lib:mainfrom
Conversation
jimhester
reviewed
Jul 10, 2020
R/install-version.R
Outdated
| package.filename <- paste(package, "_", version, ".tar.gz", | ||
| sep = "") | ||
| if (!(package.path %in% row.names(info))) { | ||
| idx <- endsWith(row.names(info), package.filename) |
Member
There was a problem hiding this comment.
What about matching with basename() instead?
Member
|
Thank you for the pull request! We recently merged a fairly substantial change to how If you are still interested in fixing this issue could you look into how this PR would work with the new code? Also please add at least a few tests to Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxes package path assumptions for archived packages (
src/contrib/Archive) indownload_version_urlby matching on the package filename only rather than the complete (relative) path. Closes #440.