feat: Add option to build image file non-interactively#258
Conversation
readefries
force-pushed
the
feat/add-flags-to-make-image-script
branch
from
47e06ab to
f74a536
Compare
|
@r0b0 I seem to be running into an issue where the package |
readefries
force-pushed
the
feat/add-flags-to-make-image-script
branch
from
f74a536 to
6208d50
Compare
Hi, This might be bacause you switched from |
| cryptsetup luksUUID "${main_partition}" > luks.uuid | ||
| root_uuid=$(cat luks.uuid) | ||
| # Add LUKS parameters to kernel cmdline | ||
| kernel_params="rd.luks.uuid=${root_uuid} rd.luks.name=${root_uuid}=${luks_device_name} rd.luks.options=tpm2-device=auto root=${root_device} ${kernel_params}" |
There was a problem hiding this comment.
I think you can leave rd.luks.uuid out when you use rd.luks.name. No biggie, just reduces the number of options.
| @@ -0,0 +1,3 @@ | |||
| # Build full initramfs with all drivers instead of host-only | |||
| # This ensures the initramfs works across different hardware configurations | |||
| hostonly="no" | |||
There was a problem hiding this comment.
There already is a hostonly="no" in 90-odin.conf
There was a problem hiding this comment.
It was needed, as during my tests installing a new system it didn't work when this wasn't added
There was a problem hiding this comment.
That is weird because your are not in fact copying your 10-no-hostonly.conf file to the actual image (using install_file()), are you?
No, that doesn't change the result. The only reason I used apt-get, is that I now apt is not script safe. But I can just remove that. |
readefries
force-pushed
the
feat/add-flags-to-make-image-script
branch
3 times, most recently
from
1875cc1 to
a8162b1
Compare
…r the root file system, so the new kernel also boots
… with options to feed settings via environment variables Signed-off-by: Hendrik Bruinsma <hbruinsma@xs4some.nl>
readefries
force-pushed
the
feat/add-flags-to-make-image-script
branch
from
a8162b1 to
42973db
Compare
| # In containers, /dev/loopN nodes can be sparse (for example missing loop1). | ||
| # Try explicitly to attach using existing block devices. | ||
| for loop_dev in /dev/loop[0-9]*; do | ||
| if [[ "${loop_dev}" =~ p[0-9]+$ ]]; then |
|
|
||
| Build compiled components with: | ||
|
|
||
| ./build-compiled-components.sh |
There was a problem hiding this comment.
./internal-tools/build-compiled-components.sh
| exit 1 | ||
| fi | ||
| DISK=${LOOP_DEVICE} | ||
| udevadm settle |
There was a problem hiding this comment.
Maybe move this block after the install required packages block to make sure udevadm is actually installed at this point
| Minimal host/VM package set for `make_image.sh`: | ||
|
|
||
| sudo apt update | ||
| sudo apt install -y btrfs-progs debootstrap dosfstools golang-go kpartx npm systemd-repart udev uuid-runtime |
There was a problem hiding this comment.
No need to point this out for the user; the script will install these
2 participants
I wanted to be able to create disk images, so I updated the
make_image.shscript to support creating an image as an option, in addition to writing directly to a USB disk.This also includes an option to select which tasksel packages to install, so the installer can be non-interactive.