[test-generator] Cover observability log rotation guardrails#1106
Merged
Conversation
…2026-06-13-log-rotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing coverage
Recent observability work added
ObservabilityLogRotation.rotateIfNeeded(...), and the fast runner already compiles the seam, but there was no direct behavior coverage for the rotation boundary, rename result, previous-generation replacement, or owner-only permissions. I kept this separate from open PR #1103 by adding a dedicated log-rotation test file instead of editing the adjacent log-writer tests.Tests added
.1generation by rename.Checks run
bash run-tests.sh --filter ObservabilityLogRotation(12 passed)bash scripts/dev/agent-preflight.shbash -n run-tests.shbash -n scripts/entrypoints/run-tests.shbash build-deps.sh --force(needed afterbuild.sh --no-openreported stale deps)bash build.sh --no-openbash run-tests.sh(5232 passed)