Skip to content

[test-generator] Cover observability log rotation guardrails#1106

Merged
r3dbars merged 2 commits into
mainfrom
codex/test-generator-2026-06-13-log-rotation
Jun 15, 2026
Merged

[test-generator] Cover observability log rotation guardrails#1106
r3dbars merged 2 commits into
mainfrom
codex/test-generator-2026-06-13-log-rotation

Conversation

@r3dbars

@r3dbars r3dbars commented Jun 13, 2026

Copy link
Copy Markdown
Owner

Missing coverage

Recent observability work added ObservabilityLogRotation.rotateIfNeeded(...), and the fast runner already compiles the seam, but there was no direct behavior coverage for the rotation boundary, rename result, previous-generation replacement, or owner-only permissions. I kept this separate from open PR #1103 by adding a dedicated log-rotation test file instead of editing the adjacent log-writer tests.

Tests added

  • Missing log files are no-op guardrails.
  • Files exactly at the threshold stay active.
  • Oversized JSONL logs move to the .1 generation by rename.
  • A new rotation replaces the prior generation and tightens the rotated file to owner-only permissions.

Checks run

  • bash run-tests.sh --filter ObservabilityLogRotation (12 passed)
  • bash scripts/dev/agent-preflight.sh
  • bash -n run-tests.sh
  • bash -n scripts/entrypoints/run-tests.sh
  • bash build-deps.sh --force (needed after build.sh --no-open reported stale deps)
  • bash build.sh --no-open
  • bash run-tests.sh (5232 passed)

@r3dbars r3dbars marked this pull request as ready for review June 15, 2026 15:27
@r3dbars r3dbars merged commit d977464 into main Jun 15, 2026
3 checks passed
@r3dbars r3dbars deleted the codex/test-generator-2026-06-13-log-rotation branch June 15, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant